-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DirectX][Docs] Add DXILIntrinsicExpansion Pass to DXILArchitecture.rst #86198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-backend-directx Author: Farzon Lotfi (farzonl) Changesfor instruction expansion Full diff: https://github.com/llvm/llvm-project/pull/86198.diff 1 Files Affected:
diff --git a/llvm/docs/DirectX/DXILArchitecture.rst b/llvm/docs/DirectX/DXILArchitecture.rst
index d6712bea4f7712..b3d29cba0a3c95 100644
--- a/llvm/docs/DirectX/DXILArchitecture.rst
+++ b/llvm/docs/DirectX/DXILArchitecture.rst
@@ -61,6 +61,19 @@ on the utilities described in "Common Code" above in order to share
logic with both the DirectX backend and with Clang's codegen of HLSL
support as much as possible.
+The DirectX Intrinsic Expansion Pass
+===================
+There are intrinsics that don't map directly to DXIL Ops. In some cases
+an intrinsic needs to be expanded to a set of LLVM IR instructions. In
+other cases an intrinsic needs modifications to the arguments or return
+values of a DXIL Op. This pass (`DXILIntrinsicExpansion.cpp`) handles all
+the cases where our intrinsics don't have a one to one mapping. You should
+also consider using this pass when the expansion is specific to DXIL so
+as to keep implementation details out of CodeGen. Finally, there is an
+expectation that we maintain vectors through this pass. Therefore, best
+practice would be to avoid scalarization in this pass.
+
+
The DirectX Backend
===================
|
for instruction expansion
farzonl
force-pushed
the
dxil-docs-instruction-expansion
branch
from
March 21, 2024 21:16
78392ba
to
be275a0
Compare
Is there anything we can do with the PR title so that the key bit of information (ie that it is about instruction expansion) doesn't fall off the title? |
farzonl
changed the title
[DirectX][Docs] Update DXILArchitecture documentation
[DirectX][Docs] Add DXILIntrinsicExpansion to DXILArchitecture documentation
Mar 21, 2024
farzonl
changed the title
[DirectX][Docs] Add DXILIntrinsicExpansion to DXILArchitecture documentation
[DirectX][Docs] Add DXILIntrinsicExpansion Pass to DXILArchitecture documentation
Mar 21, 2024
farzonl
changed the title
[DirectX][Docs] Add DXILIntrinsicExpansion Pass to DXILArchitecture documentation
[DirectX][Docs] Add DXILIntrinsicExpansion Pass to DXILArchitecture.rst
Mar 21, 2024
damyanp
approved these changes
Mar 21, 2024
llvm-beanz
approved these changes
Mar 21, 2024
chencha3
pushed a commit
to chencha3/llvm-project
that referenced
this pull request
Mar 23, 2024
…st (llvm#86198) Completes llvm#84839 --------- Co-authored-by: Farzon Lotfi <farzon@farzon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #84839