Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Passes] Expose parseSinglePassOption" #86225

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

paperchalice
Copy link
Contributor

Reverts #86117

@paperchalice paperchalice merged commit 8d7d581 into main Mar 22, 2024
3 of 5 checks passed
@paperchalice paperchalice deleted the revert-86117-pb branch March 22, 2024 00:54
Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 3e4caa9da4356247444e973eb470a25adae083b0 012438a2760b5bf89daa7e9b18848510f514d09c -- llvm/include/llvm/Passes/PassBuilder.h llvm/lib/Passes/PassBuilder.cpp
View the diff from clang-format here.
diff --git a/llvm/lib/Passes/PassBuilder.cpp b/llvm/lib/Passes/PassBuilder.cpp
index 9d98ae7dde..4b1db18b54 100644
--- a/llvm/lib/Passes/PassBuilder.cpp
+++ b/llvm/lib/Passes/PassBuilder.cpp
@@ -620,7 +620,8 @@ Expected<bool> parseSinglePassOption(StringRef Params, StringRef OptionName,
 }
 
 Expected<bool> parseGlobalDCEPassOptions(StringRef Params) {
-  return parseSinglePassOption(Params, "vfe-linkage-unit-visibility", "GlobalDCE");
+  return parseSinglePassOption(Params, "vfe-linkage-unit-visibility",
+                               "GlobalDCE");
 }
 
 Expected<bool> parseCGProfilePassOptions(StringRef Params) {
@@ -1062,8 +1063,7 @@ Expected<std::string> parseMemProfUsePassOptions(StringRef Params) {
 }
 
 Expected<bool> parseStructuralHashPrinterPassOptions(StringRef Params) {
-  return parseSinglePassOption(Params, "detailed",
-                               "StructuralHashPrinterPass");
+  return parseSinglePassOption(Params, "detailed", "StructuralHashPrinterPass");
 }
 
 Expected<bool> parseWinEHPrepareOptions(StringRef Params) {

paperchalice added a commit that referenced this pull request Mar 22, 2024
delcypher pushed a commit to apple/llvm-project that referenced this pull request Mar 22, 2024
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant