[RemoveDIs] Do not load into new debug info format from bitcode by default #86268
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault This is NFC right now, as the default behaviour is "do not load into the new debug info format by default", but we want to change that soon. Additionally unconditionally convert from the new debug info format into if we've loaded into it (e.g., if the bitcode file loaded was already in the new format). The latter change is needed because verify-uselistorder doesn't yet understand DbgRecords (it doesn't know how to map them). The former change is needed because if we load from an old debug format bitcode file but load directly into the new format _and then convert back to the old mode after_, the use-lists of the debug intrinsic functions (the functions' global value uses) change.
jmorse
reviewed
Mar 22, 2024
Oops, a typo in the patch that added the flag. I'll fix that separately.
Yep, I'm going to upload more patches that enable the bitcode loading by default in specific tools (e.g. #86271). The intention is that once those stick for a while we can make it the global default. |
jryans
approved these changes
Mar 22, 2024
| @@ -68,6 +68,7 @@ static cl::opt<unsigned> | |||
| cl::desc("Number of times to shuffle and verify use-lists"), | |||
| cl::init(1), cl::cat(Cat)); | |||
|
|
|||
| extern cl::opt<cl::boolOrDefault> LoadBitcodeIntoNewDbgInforFormat; | |||
There was a problem hiding this comment.
Nit: Probably better to keep a blank line after this
|
This is causing failed builds here: I pushed a fix in 336bdf1. |
|
Thanks very much for sorting that out - I renamed the variable (to fix the typo), but didn't remember to update this PR before pushing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is NFC right now, as the global default behaviour is also "do not load into the new debug info format by default", but we want to change that soon.
Additionally unconditionally convert from the new debug info format into if we've loaded into it (e.g., if the bitcode file loaded was already in the new format).
The latter change is needed because verify-uselistorder doesn't yet understand DbgRecords (it doesn't know how to map them).
The former change is needed because if we load from an old debug format bitcode file but load directly into the new format and then convert back to the old mode after, the use-lists of the debug intrinsic functions (the functions' global value uses) change.