[RemoveDIs] Load into new debug info format by default in llvm-dis #86276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SLTozer
approved these changes
Mar 22, 2024
llvm/tools/llvm-dis/llvm-dis.cpp
Outdated
| @@ -82,6 +82,9 @@ static cl::opt<bool> PrintThinLTOIndexOnly( | |||
|
|
|||
| extern cl::opt<bool> WriteNewDbgInfoFormat; | |||
|
|
|||
| extern cl::opt<bool> WriteNewDbgInfoFormat; | |||
There was a problem hiding this comment.
Whoops, yep, that just fell out of a badly applied patch. Thanks!
jryans
approved these changes
Mar 22, 2024
| @@ -168,6 +169,9 @@ int main(int argc, char **argv) { | |||
|
|
|||
| cl::HideUnrelatedOptions({&DisCategory, &getColorCategory()}); | |||
| cl::ParseCommandLineOptions(argc, argv, "llvm .bc -> .ll disassembler\n"); | |||
| // Load bitcode into the new debug info format by default. | |||
There was a problem hiding this comment.
Nit: Again perhaps add a line above here, but it's a minor stylistic point.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly load all bitcode into the new debug info format in llvm-dis. This means that new-mode bitcode no longer round-trips back to old-mode after parsing, and that old-mode bitcode gets auto-upgraded to new-mode debug info (which is the current in-memory default in LLVM).