Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc] fix missing macro dependency in bazel #86298

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

SchrodingerZhu
Copy link
Contributor

image

@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels Mar 22, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 22, 2024

@llvm/pr-subscribers-libc

Author: Schrodinger ZHU Yifan (SchrodingerZhu)

Changes

image


Full diff: https://github.com/llvm/llvm-project/pull/86298.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel (+1)
diff --git a/utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel
index 803010e8b3add5..5f59d70ecc16d0 100644
--- a/utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/utils/MPFRWrapper/BUILD.bazel
@@ -46,6 +46,7 @@ libc_support_library(
         "//libc:__support_cpp_type_traits",
         "//libc:__support_fputil_fp_bits",
         "//libc:__support_fputil_fpbits_str",
+        "//libc:llvm_libc_macros_math_macros",
         "//libc/test/UnitTest:LibcUnitTest",
         "//libc/test/UnitTest:fp_test_helpers",
         "//libc/utils/MPFRWrapper:mpfr_impl",

Copy link
Contributor

@michaelrj-google michaelrj-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch LGTM

In future it's better to copy the actual text of the error instead of using an image. It makes it more searchable/readable.

@SchrodingerZhu
Copy link
Contributor Author

ERROR: /home/schrodingerzy/.cache/bazel/_bazel_schrodingerzy/7304816608f0590331fc5bd443889928/external/llvm-project/libc/utils/MPFRWrapper/BUILD.bazel:29:21: Compiling libc/utils/MPFRWrapper/MPFRUtils.cpp failed: (Exit 1): clang-17 failed: error executing command (from target @llvm-project//libc/utils/MPFRWrapper:mpfr_wrapper) /usr/bin/clang-17 -U_FORTIFY_SOURCE -fstack-protector -Wall -Wthread-safety -Wself-assign -Wunused-but-set-parameter -Wno-free-nonheap-object -fcolor-diagnostics -fno-omit-frame-pointer '-std=c++0x' ... (remaining 103 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
external/llvm-project/libc/utils/MPFRWrapper/MPFRUtils.cpp:17:10: error: module @llvm-project//libc/utils/MPFRWrapper:mpfr_wrapper does not depend on a module exporting 'include/llvm-libc-macros/math-macros.h'
   17 | #include "include/llvm-libc-macros/math-macros.h"
      |          ^
1 error generated.
INFO: Elapsed time: 4.935s, Critical Path: 1.77s
INFO: 298 processes: 60 internal, 238 linux-sandbox.
FAILED: Build did NOT complete successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel libc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants