Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMake][HLSL] Add SPIRV to target list for build #86323

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

llvm-beanz
Copy link
Collaborator

This change just enables the SPIR-V target by default in the HLSL build configurations. Since SPIR-V support is something we expect from the full HLSL compiler releases for pairity with DXC we should enable it in the default developer workflow.

This change just enables the SPIR-V target by default in the HLSL build
configurations. Since SPIR-V support is something we expect from the
full HLSL compiler releases for pairity with DXC we should enable it in
the default developer workflow.
@llvmbot llvmbot added clang Clang issues not falling into any other category HLSL HLSL Language Support labels Mar 22, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Mar 22, 2024

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-hlsl

Author: Chris B (llvm-beanz)

Changes

This change just enables the SPIR-V target by default in the HLSL build configurations. Since SPIR-V support is something we expect from the full HLSL compiler releases for pairity with DXC we should enable it in the default developer workflow.


Full diff: https://github.com/llvm/llvm-project/pull/86323.diff

1 Files Affected:

  • (modified) clang/cmake/caches/HLSL.cmake (+1-1)
diff --git a/clang/cmake/caches/HLSL.cmake b/clang/cmake/caches/HLSL.cmake
index 71f81e53f6bd35..84850c86f12cd7 100644
--- a/clang/cmake/caches/HLSL.cmake
+++ b/clang/cmake/caches/HLSL.cmake
@@ -4,7 +4,7 @@ set(LLVM_TARGETS_TO_BUILD Native CACHE STRING "")
 
 # Include the DirectX target for DXIL code generation, eventually we'll include
 # SPIR-V here too.
-set(LLVM_EXPERIMENTAL_TARGETS_TO_BUILD DirectX CACHE STRING "")
+set(LLVM_EXPERIMENTAL_TARGETS_TO_BUILD "DirectX;SPIRV" CACHE STRING "")
 
 # HLSL support is currently limted to clang, eventually it will expand to
 # clang-tools-extra too.

Copy link
Contributor

@coopp coopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPIRV in the house!

@llvm-beanz llvm-beanz merged commit ded6252 into llvm:main Mar 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category HLSL HLSL Language Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants