[BOLT] Skip functions with unsupported Linux kernel features #86345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not overwrite functions with alternative and paravirtual instructions until a proper update support is implemented.
maksfb
requested review from
aaupov,
rafaelauler,
ayermolo and
dcci
as code owners
|
✅ With the latest revision this PR passed the Python code formatter. |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
aaupov
requested changes
Mar 22, 2024
Comment on lines
1144
to
1145
| if (!BC.shouldEmit(BF)) | ||
| break; |
There was a problem hiding this comment.
Suggested change
| if (!BC.shouldEmit(BF)) | |
| break; |
There was a problem hiding this comment.
Why? That's intentional early break after we mark the function as non-simple in the loop below.
There was a problem hiding this comment.
Oh, that's subtle. Then I'd suggest breaking out immediately after BF.setSimple(false) to be explicit.
There was a problem hiding this comment.
It's breaking, just not to the outer loop. I've refactored using llvm::any_of() as you suggested and it looks much cleaner now.
Comment on lines
1146
to
1151
| for (const MCInst &Inst : BB) { | ||
| if (BC.MIB->hasAnnotation(Inst, "ParaSite")) { | ||
| BF.setSimple(false); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm fine with it as-is, but this can help reduce indentation:
Suggested change
| for (const MCInst &Inst : BB) { | |
| if (BC.MIB->hasAnnotation(Inst, "ParaSite")) { | |
| BF.setSimple(false); | |
| break; | |
| } | |
| } | |
| bool HasParaSite = llvm::any_of(BB, [&](const MCInst &Inst) { return BC.MIB->hasAnnotation(Inst, "ParaSite"); }); | |
| if (HasParaSite) | |
| BF.setSimple(false); |
| if (!BC.shouldEmit(BF)) | ||
| continue; | ||
| for (const BinaryBasicBlock &BB : BF) { | ||
| if (!BC.shouldEmit(BF)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not overwrite functions with alternative and paravirtual instructions until a proper update support is implemented.