[MTE] add stack frame history buffer #86356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmayer
added a commit
to fmayer/llvm-project
that referenced
this pull request
Apr 11, 2024
Pull Request: llvm#86356
eugenis
approved these changes
May 28, 2024
fmayer
merged commit 34edaaf
into
users/fmayer/spr/main.wip-mte-stack-record
2 of 3 checks passed
fmayer
added a commit
that referenced
this pull request
May 29, 2024
this will allow us to find offending objects in a symbolization step, like we can do with hwasan. needs matching changes in AOSP: https://android-review.git.corp.google.com/q/topic:%22stackhistorybuffer%22 Pull Request: #86356
|
Now actually submitted: 1f67f34 |
|
Hello @fmayer ! If I compile this patch with UBSan (-DLLVM_USE_SANITIZER='Undefined') and run tests, I see the following for many many lit tests: Can e.g. be seen with if you compiled llc with UBSan. |
should be fixed: 973821c |
jameshu15869
pushed a commit
to jameshu15869/llvm-project
that referenced
this pull request
May 31, 2024
this will allow us to find offending objects in a symbolization step, like we can do with hwasan. needs matching changes in AOSP: https://android-review.git.corp.google.com/q/topic:%22stackhistorybuffer%22 Pull Request: llvm#86356
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will allow us to find offending objects in a symbolization step,
like we can do with hwasan.
needs matching changes in AOSP:
https://android-review.git.corp.google.com/q/topic:%22stackhistorybuffer%22