[clang-tidy] Fix result check after overwriteChangedFiles()

[mikerice1969]

If any return from overwriteChangedFiles is true some fixes were not applied.

[llvmbot]

@llvm/pr-subscribers-clang-tools-extra

@llvm/pr-subscribers-clang-tidy

Author: Mike Rice (mikerice1969)

Changes

If any return from overwriteChangedFiles is true some fixes were not applied.

---

Full diff: https://github.com/llvm/llvm-project/pull/86360.diff

1 Files Affected:

• (modified) clang-tools-extra/clang-tidy/ClangTidy.cpp (+1-1)

diff --git a/clang-tools-extra/clang-tidy/ClangTidy.cpp b/clang-tools-extra/clang-tidy/ClangTidy.cpp
index 40ac6918faf407..b877ea06dc05cd 100644
--- a/clang-tools-extra/clang-tidy/ClangTidy.cpp
+++ b/clang-tools-extra/clang-tidy/ClangTidy.cpp
@@ -233,7 +233,7 @@ class ErrorReporter {
         if (!tooling::applyAllReplacements(Replacements.get(), Rewrite)) {
           llvm::errs() << "Can't apply replacements for file " << File << "\n";
         }
-        AnyNotWritten &= Rewrite.overwriteChangedFiles();
+        AnyNotWritten |= Rewrite.overwriteChangedFiles();
       }
 
       if (AnyNotWritten) {

[github-actions]

✅ With the latest revision this PR passed the Python code formatter.

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[jansvoboda11]

This could use a test.

[mikerice1969]

This could use a test.

I thought about it, but I have no idea how to write that test. Do you have an idea?

[PiotrZSL]

LGTM.
Yes looks like previously AnyNotWritten coudn't be true.

I don't see need for test / release notes.
After all the only thing this impact is a print.