Fix unassigned add handling in aarch64 #86636
Conversation
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@chansuke reverse-ping - are you still working on this please? |
| @@ -5279,6 +5279,13 @@ SDValue DAGCombiner::visitAVG(SDNode *N) { | |||
| DAG.getNode(ISD::ADD, DL, VT, N0, DAG.getAllOnesConstant(DL, VT))); | |||
| } | |||
|
|
|||
| // Fold shadd(x,y) -> uhadd(x,y) if both x and y are non-negative | |||
| if (Opcode == ISD::SHADD && !hasOperation(ISD::SHADD, VT) && | |||
There was a problem hiding this comment.
This should be ISD::AVGFLOORS + ISD::AVGFLOORU
| // Fold shadd(x,y) -> uhadd(x,y) if both x and y are non-negative | ||
| if (Opcode == ISD::SHADD && !hasOperation(ISD::SHADD, VT) && | ||
| (!LegalOperations || hasOperation(ISD::UHADD, VT))) { | ||
| if (DAG.isKnownNeverNegative(N0) && DAG.isKnownNeverNegative(N1)) |
Fixes #84746