Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unittests] Fix TableGenTests with LLVM_LINK_LLVM_DYLIB #86664

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Mar 26, 2024

Since the restructuring in commit fa3d789, the option DISABLE_LLVM_LINK_LLVM_DYLIB is counter-productive and leads to

CommandLine Error: Option 'debug-counter' registered more than once!

Since the restructuring in commit fa3d789, the option
DISABLE_LLVM_LINK_LLVM_DYLIB is counter-productive and leads to
CommandLine Error: Option 'debug-counter' registered more than once!
Copy link
Contributor

@arsenm arsenm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any other unit tests using this

Copy link
Contributor

@Pierre-vh Pierre-vh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please monitor buildbots closely afterwards

@hahnjo hahnjo merged commit 81fc43a into llvm:main Mar 26, 2024
5 checks passed
@hahnjo hahnjo deleted the unittests-TableGen-dylib branch March 26, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants