release/18x: [OpenMP][AIX] Affinity implementation for AIX (#84984) #86695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xingxue-ibm
requested review from
tstellar,
brad0,
shiltian,
kkwli and
jpeyton52
|
I think it's fine. WDYT? @tstellar |
|
@kkwli What do you think about this? |
shiltian
approved these changes
Mar 29, 2024
brad0
approved these changes
Mar 30, 2024
This patch implements `affinity` for AIX, which is quite different from platforms such as Linux. - Setting CPU affinity through masks and related functions are not supported. System call `bindprocessor()` is used to bind a thread to one CPU per call. - There are no system routines to get the affinity info of a thread. The implementation of `get_system_affinity()` for AIX gets the mask of all available CPUs, to be used as the full mask only. - Topology is not available from the file system. It is obtained through system SRAD (Scheduler Resource Allocation Domain). This patch has run through the libomp LIT tests successfully with `affinity` enabled. (cherry picked from commit d394f3a)
xingxue-ibm
force-pushed
the
backport-84984
branch
from
1158e9e
to
47aac49
Compare
|
Hi @xingxue-ibm (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. |
Thank you very much, @tstellar! We don't have anything specific to add to the release notes at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements
affinityfor AIX, which is quite different from platforms such as Linux.bindprocessor()is used to bind a thread to one CPU per call.get_system_affinity()for AIX gets the mask of all available CPUs, to be used as the full mask only.This patch has run through the libomp LIT tests successfully with
affinityenabled.(cherry picked from commit d394f3a)
Note: We need to include this patch in the libomp of the next IBM OpenXL for AIX compiler deliverable which is built off LLVM v18. This cherry-pick has been re-based on
release/18.x. Changes in this patch are guarded for AIX and should not affect other platforms.