Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC][HWASAN] Precommit globals-access test #86771

Merged

Conversation

vitalybuka
Copy link
Collaborator

HWASAN does not behave as expected yet.

Created using spr 1.3.4
Created using spr 1.3.4
Created using spr 1.3.4
@vitalybuka vitalybuka merged commit 96b3969 into main Mar 27, 2024
3 of 4 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/nfchwasan-precommit-globals-access-test branch March 27, 2024 17:30
@dyung
Copy link
Collaborator

dyung commented Mar 27, 2024

@vitalybuka your NFC test commit is failing on several bots, can you take a look or revert if you need time to investigate?

@vitalybuka
Copy link
Collaborator Author

Will do, but bot link could be helpful

@dyung
Copy link
Collaborator

dyung commented Mar 27, 2024

@vitalybuka
Copy link
Collaborator Author

I thought the bots are supposed to automatically email

Not for me, for the record, and rest of community who are not on the blame list of the patch.

vitalybuka added a commit that referenced this pull request Mar 27, 2024
vitalybuka added a commit that referenced this pull request Mar 27, 2024
@dyung
Copy link
Collaborator

dyung commented Mar 28, 2024

I thought the bots are supposed to automatically email

Not for me, for the record, and rest of community who are not on the blame list of the patch.

I am curious, did you not receive an email telling you this run had failed on this bot?

https://lab.llvm.org/buildbot/#/builders/139/builds/62303

This builder builds every commit one by one, and your commit is the only one built in this change when it failed.

@vitalybuka
Copy link
Collaborator Author

I am curious, did you not receive an email telling you this run had failed on this bot?

Yes, there is a message in my inbox which I read after your comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants