[mlir][bazel] Export headers either from :Transforms or :TransformUtils #86819
+116
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split them according to their implementation. Ideally, header files should be used by only one target, but this is hard because CMake is less strict with headers (no layering check). But even with bazel, headers should only be exported once in the `hdrs` attribute. Other targets may use them in the `srcs` attribute to avoid circular dependencies.
rupprecht
approved these changes
Mar 27, 2024
Comment on lines
+7548
to
+7560
| hdrs = [ | ||
| "include/mlir/Transforms/CFGToSCF.h", | ||
| "include/mlir/Transforms/CommutativityUtils.h", | ||
| "include/mlir/Transforms/ControlFlowSinkUtils.h", | ||
| "include/mlir/Transforms/DialectConversion.h", | ||
| "include/mlir/Transforms/FoldUtils.h", | ||
| "include/mlir/Transforms/GreedyPatternRewriteDriver.h", | ||
| "include/mlir/Transforms/Inliner.h", | ||
| "include/mlir/Transforms/LoopInvariantCodeMotionUtils.h", | ||
| "include/mlir/Transforms/OneToNTypeConversion.h", | ||
| "include/mlir/Transforms/RegionUtils.h", | ||
| "include/mlir/Transforms/TopologicalSortUtils.h", | ||
| ], |
There was a problem hiding this comment.
If the .cpp files are in lib/Transforms/Utils, why are the corresponding headers in include/mlir/Transforms, and not include/mlir/Transforms/Utils? Ideally you could have this be glob(["include/mlir/Transforms/Utils/*.cpp"]) to match the srcs glob(["lib/Transforms/Utils/*.cpp"]).
Is it feasible to move those files? How big of a change would that be?
There was a problem hiding this comment.
That might make sense, but I don't really want to start another discussion about moving code around to better match the bazel build graph.
| @@ -7851,7 +7887,16 @@ cc_library( | |||
| srcs = glob([ | |||
| "lib/Transforms/*.cpp", | |||
| ]), | |||
| hdrs = glob(["include/mlir/Transforms/*.h"]), | |||
| hdrs = [ | |||
There was a problem hiding this comment.
(likewise, it'd be nice if this could remain as glob(["include/mlir/Transforms/*.h"]))
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 27, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 619443019
copybara-service bot
pushed a commit
to google/heir
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 620006777
copybara-service bot
pushed a commit
to tensorflow/mlir-hlo
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 620006777
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 620006777
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 28, 2024
…on for llvm/llvm-project#86819. PiperOrigin-RevId: 620006777
bjacob
added a commit
to iree-org/iree
that referenced
this pull request
Apr 3, 2024
IREE-side changes to adapt to MLIR changes: 1. `initializeOptions` changes to adapt to llvm/llvm-project#87289 2. `enableFastMathMode` removal: llvm/llvm-project#86578. 3. Bazel changes to adapt to llvm/llvm-project#86819 IREE-side fixes for preexisting bugs revealed by a MLIR change: 1. `mlp_tosa` test fix: the shapes were inconsistent, used to accidentally work, until MLIR started catching it since llvm/llvm-project#85798. See diagnostic in [87396](llvm/llvm-project#87396 (comment)). FYI @MaheshRavishankar. IREE-side fixes accidentally lumped into this: 1. The `iree_copts.cmake` change: It just happens that my bleeding-edge Clang was updated and started diagnosing some code relying on C++20 semantics. Filed #16946 as TODO. --------- Co-authored-by: Scott Todd <scott.todd0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split them according to their implementation.
Ideally, header files should be used by only one target, but this is hard because CMake is less strict with headers (no layering check). But even with bazel, headers should only be exported once in the
hdrsattribute. Other targets may use them in thesrcsattribute to avoid circular dependencies.