[bazel] Add support for LLVM_TOOL_LLVM_DRIVER_BUILD #86879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the bazel equivalent of the `llvm` binary produced by `LLVM_TOOL_LLVM_DRIVER_BUILD` in cmake. For the initial commit, this only includes `llvm-ar`, `llvm-nm`, and `llvm-size`. The rest are trivial to add in a followup commit, following the same pattern as here.
By default it will include everything that supports the llvm-driver model, but it can be reduced to only build a subset, e.g. this will build only nm and size:
```
$ bazel build \
--@llvm-project//llvm:driver-tools=llvm-nm,llvm-size \
@llvm-project//llvm:llvm
```
MaskRay
approved these changes
Mar 28, 2024
| @@ -4178,6 +4187,12 @@ cc_binary( | |||
| ], | |||
| ) | |||
|
|
|||
| llvm_driver_cc_binary( | |||
| name = "llvm-nm", | |||
| stamp = 0, | |||
There was a problem hiding this comment.
Do we need guidance when and where we use stamp = 0 （https://bazel.build/reference/be/c-cpp） as a comment?
There was a problem hiding this comment.
Good question. Some people may have strong opinions on stamping. I'm not sure if there's a reason we have stamp = 0 in these build files. Obviously there are caching benefits, but you also get those more broadly by building with bazel build --nostamp. I can't find advice on this, e.g. in a style guide or best practices list, but I'll add a comment later if I can figure anything out.
(btw, this looks like a new line, but it's just moved from a few lines above)
MaskRay
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the bazel equivalent of the
llvmbinary produced byLLVM_TOOL_LLVM_DRIVER_BUILDin cmake. For the initial commit, this only includesllvm-ar,llvm-nm, andllvm-size. The rest are trivial to add in a followup commit, following the same pattern as here.By default it will include everything that supports the llvm-driver model, but it can be reduced to only build a subset, e.g. this will build only nm and size: