Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tsan][test] Remove some unneded debug comments in a tsan test #86896

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

canova
Copy link
Contributor

@canova canova commented Mar 28, 2024

I introduced this test in #86537, let's remove some unneeded debugging comments.
This PR was initially also moving the test to linux directory but looks like it's already done by 17ab9e6 .

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 28, 2024

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Nazım Can Altınova (canova)

Changes

I introduced this test in #86537 but it should only be run on Linux since it's tests Linux syscalls specifically.
This PR moves it to compiler-rt/test/tsan/Linux/ subdirectory, and removes some unneeded debugging comments in the meantime.


Full diff: https://github.com/llvm/llvm-project/pull/86896.diff

1 Files Affected:

  • (renamed) compiler-rt/test/tsan/Linux/signal_in_futex_wait.cpp (-3)
diff --git a/compiler-rt/test/tsan/signal_in_futex_wait.cpp b/compiler-rt/test/tsan/Linux/signal_in_futex_wait.cpp
similarity index 94%
rename from compiler-rt/test/tsan/signal_in_futex_wait.cpp
rename to compiler-rt/test/tsan/Linux/signal_in_futex_wait.cpp
index cf31e5467486ad..485d87d5ee846c 100644
--- a/compiler-rt/test/tsan/signal_in_futex_wait.cpp
+++ b/compiler-rt/test/tsan/Linux/signal_in_futex_wait.cpp
@@ -57,16 +57,13 @@ class Mutex {
 Mutex mutex;
 
 void *Thread(void *x) {
-  // fprintf(stderr, "canova here thread 0\n");
   // Waiting for the futex.
   mutex.lock();
-  // fprintf(stderr, "canova here thread 1\n");
   // Finished waiting.
   return nullptr;
 }
 
 static void SigprofHandler(int signal, siginfo_t *info, void *context) {
-  // fprintf(stderr, "canova here sigprof handler\n");
   // Unlock the futex.
   mutex.unlock();
 }

@vitalybuka
Copy link
Collaborator

Already done 17ab9e6

@vitalybuka
Copy link
Collaborator

Please rebase, and update description for the rest :)

@vitalybuka vitalybuka self-requested a review March 28, 2024 00:58
@canova
Copy link
Contributor Author

canova commented Mar 28, 2024

Ah you beat me to it :) Will rebase for the comment removals in a bit.

@canova canova changed the title [tsan][test] Move the linux specific TSan test to the linux subdirectory [tsan][test] Remove some unneded debug comments in a tsan test Mar 28, 2024
@canova
Copy link
Contributor Author

canova commented Mar 28, 2024

@vitalybuka updated the PR, thanks for taking care of the test failure!

@vitalybuka vitalybuka merged commit cc98ffb into llvm:main Mar 28, 2024
4 checks passed
@canova canova deleted the tsan-futex-linux branch March 28, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants