Fix #86269: remove unused variable #86927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-llvm-transforms Author: Shan Huang (Apochens) ChangesRemove the unused variable Full diff: https://github.com/llvm/llvm-project/pull/86927.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp b/llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp
index 34d39f3fe6dcac..10c92395b4777a 100644
--- a/llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp
+++ b/llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp
@@ -509,7 +509,7 @@ void TailRecursionEliminator::createTailRecurseLoopHeader(CallInst *CI) {
BasicBlock *NewEntry = BasicBlock::Create(F.getContext(), "", &F, HeaderBB);
NewEntry->takeName(HeaderBB);
HeaderBB->setName("tailrecurse");
- BranchInst *BI = BranchInst::Create(HeaderBB, NewEntry);
+ BranchInst::Create(HeaderBB, NewEntry);
// If the new branch preserves the debug location of CI, it could result in
// misleading stepping, if CI is located in a conditional branch.
// So, here we don't give any debug location to BI.
|
| @@ -509,7 +509,7 @@ void TailRecursionEliminator::createTailRecurseLoopHeader(CallInst *CI) { | |||
| BasicBlock *NewEntry = BasicBlock::Create(F.getContext(), "", &F, HeaderBB); | |||
| NewEntry->takeName(HeaderBB); | |||
| HeaderBB->setName("tailrecurse"); | |||
| BranchInst *BI = BranchInst::Create(HeaderBB, NewEntry); | |||
| BranchInst::Create(HeaderBB, NewEntry); | |||
| // If the new branch preserves the debug location of CI, it could result in | |||
| // misleading stepping, if CI is located in a conditional branch. | |||
| // So, here we don't give any debug location to BI. | |||
There was a problem hiding this comment.
Since there is no "BI" variable anymore it's confusing to reference it in the comment.
Perhaps change "BI" to "the new branch"?
There was a problem hiding this comment.
Refinement is committed.
mikaelholmen
approved these changes
Mar 28, 2024
|
Please help in merging this PR if it's ready, cause I don't have the permission. Thanks! |
Done. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unused variable
BIintroduced in #86269.