Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clangd][trace] Fix comment to mention that trace spans are measured … #86938

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

VitaNuo
Copy link
Contributor

@VitaNuo VitaNuo commented Mar 28, 2024

…in milliseconds rather than seconds.

@llvmbot
Copy link
Collaborator

llvmbot commented Mar 28, 2024

@llvm/pr-subscribers-clang-tools-extra

@llvm/pr-subscribers-clangd

Author: None (VitaNuo)

Changes

…in milliseconds rather than seconds.


Full diff: https://github.com/llvm/llvm-project/pull/86938.diff

1 Files Affected:

  • (modified) clang-tools-extra/clangd/support/Trace.h (+2-2)
diff --git a/clang-tools-extra/clangd/support/Trace.h b/clang-tools-extra/clangd/support/Trace.h
index 1bfc75b874d8a9..36c3745a41e969 100644
--- a/clang-tools-extra/clangd/support/Trace.h
+++ b/clang-tools-extra/clangd/support/Trace.h
@@ -143,8 +143,8 @@ bool enabled();
 class Span {
 public:
   Span(llvm::Twine Name);
-  /// Records span's duration in seconds to \p LatencyMetric with \p Name as the
-  /// label.
+  /// Records span's duration in milliseconds to \p LatencyMetric with \p Name
+  /// as the label.
   Span(llvm::Twine Name, const Metric &LatencyMetric);
   ~Span();
 

@VitaNuo VitaNuo self-assigned this Mar 28, 2024
@VitaNuo VitaNuo requested a review from kadircet March 28, 2024 11:49
@VitaNuo VitaNuo merged commit 56a10a3 into llvm:main Mar 28, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants