[clang] Add invalid check in NormalizedConstraint::fromConstraintExpr.

[hokein]

This is an oversight spot in #86869, we should always check the invalid bit after constructing the Sema::InstantiatingTemplate RAII object.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Haojian Wu (hokein)

Changes

This is an oversight spot in #86869, we should always check the invalid bit after constructing the Sema::InstantiatingTemplate RAII object.

---

Full diff: https://github.com/llvm/llvm-project/pull/86943.diff

1 Files Affected:

• (modified) clang/lib/Sema/SemaConcept.cpp (+2)

diff --git a/clang/lib/Sema/SemaConcept.cpp b/clang/lib/Sema/SemaConcept.cpp
index a2d8ba9a96d7a4..61979816bf4e3c 100644
--- a/clang/lib/Sema/SemaConcept.cpp
+++ b/clang/lib/Sema/SemaConcept.cpp
@@ -1356,6 +1356,8 @@ NormalizedConstraint::fromConstraintExpr(Sema &S, NamedDecl *D, const Expr *E) {
           S, CSE->getExprLoc(),
           Sema::InstantiatingTemplate::ConstraintNormalization{}, D,
           CSE->getSourceRange());
+      if (Inst.isInvalid())
+        return std::nullptr;
       // C++ [temp.constr.normal]p1.1
       // [...]
       // The normal form of an id-expression of the form C<A1, A2, ..., AN>,

[Sirraide]

There’s a typo, but LGTM otherwise.