[M68k] Change gcc register name from a7 to sp.

[tclin914]

In M68kRegisterInfo.td, register SP is defined with name sp and alternate name a7.

Fixes: #78620

[llvmbot]

@llvm/pr-subscribers-backend-m68k

@llvm/pr-subscribers-clang

Author: Jim Lin (tclin914)

Changes

In M68kRegisterInfo.td, register SP is defined with name sp and alternate name a7.

Fixes: #78620

---

Full diff: https://github.com/llvm/llvm-project/pull/87095.diff

1 Files Affected:

• (modified) clang/lib/Basic/Targets/M68k.cpp (+1-1)

diff --git a/clang/lib/Basic/Targets/M68k.cpp b/clang/lib/Basic/Targets/M68k.cpp
index 1b7e0a7f32c9be..9e6b59f1e42a8d 100644
--- a/clang/lib/Basic/Targets/M68k.cpp
+++ b/clang/lib/Basic/Targets/M68k.cpp
@@ -127,7 +127,7 @@ bool M68kTargetInfo::hasFeature(StringRef Feature) const {
 
 const char *const M68kTargetInfo::GCCRegNames[] = {
     "d0", "d1", "d2", "d3", "d4", "d5", "d6", "d7",
-    "a0", "a1", "a2", "a3", "a4", "a5", "a6", "a7",
+    "a0", "a1", "a2", "a3", "a4", "a5", "a6", "sp",
     "pc"};
 
 ArrayRef<const char *> M68kTargetInfo::getGCCRegNames() const {

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff d3bc9cc99b3d45e1fb8d65a57e308e899439fe26 c91fb8eacd5a156185df0b94819f02d671f9ed66 -- clang/test/CodeGen/M68k/inline-asm-gcc-regs.c clang/lib/Basic/Targets/M68k.cpp clang/lib/Basic/Targets/M68k.h

View the diff from clang-format here.

diff --git a/clang/lib/Basic/Targets/M68k.cpp b/clang/lib/Basic/Targets/M68k.cpp
index 8b8bf97d6f..d018984224 100644
--- a/clang/lib/Basic/Targets/M68k.cpp
+++ b/clang/lib/Basic/Targets/M68k.cpp
@@ -126,9 +126,8 @@ bool M68kTargetInfo::hasFeature(StringRef Feature) const {
 }
 
 const char *const M68kTargetInfo::GCCRegNames[] = {
-    "d0", "d1", "d2", "d3", "d4", "d5", "d6", "d7",
-    "a0", "a1", "a2", "a3", "a4", "a5", "a6", "sp",
-    "pc"};
+    "d0", "d1", "d2", "d3", "d4", "d5", "d6", "d7", "a0",
+    "a1", "a2", "a3", "a4", "a5", "a6", "sp", "pc"};
 
 ArrayRef<const char *> M68kTargetInfo::getGCCRegNames() const {
   return llvm::ArrayRef(GCCRegNames);

[mshockwave]

Is it possible use TargetInfo::getGCCRegAliases to model the aliasing between a7 and sp?
Also, could you add a simple test?

[tclin914]

Is it possible use TargetInfo::getGCCRegAliases to model the aliasing between a7 and sp? Also, could you add a simple test?

Implement getGCCRegAliases and add testcase.

[mshockwave]

Thank you! LGTM