Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP] arm64_32 port for Apple WatchOS #87246

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

nihui
Copy link
Contributor

@nihui nihui commented Apr 1, 2024

detect aarch64_32 with compiler defined macro __ARM64_ARCH_8_32__
reuse ARM __kmp_unnamed_critical_addr and add KMP_PREFIX_UNDERSCORE macro like AARCH64
reuse AARCH64 __kmp_invoke_microtask

build log for watchos armv7k + arm64_32 and watchos simulator x86_64 + arm64
https://github.com/nihui/action-protobuf/actions/runs/8520684611/job/23337305030

@llvmbot llvmbot added openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime labels Apr 1, 2024
@nihui nihui marked this pull request as draft April 2, 2024 09:36
@nihui nihui marked this pull request as ready for review April 2, 2024 09:43
@nihui nihui force-pushed the arm64_32 branch 2 times, most recently from 3e0ac7a to 81931f2 Compare April 2, 2024 11:31
@shiltian
Copy link
Contributor

shiltian commented Apr 2, 2024

What is aarch64_32? Is it a 32-bit arch?

@shiltian shiltian self-requested a review April 2, 2024 13:40
@nihui
Copy link
Contributor Author

nihui commented Apr 2, 2024

What is aarch64_32? Is it a 32-bit arch?

arm64_32 is a variant of arm64 with 32-bit pointer sizes, used on Apple Watch Series 4 and later.
llvm triple is named with aarch64_32 since https://reviews.llvm.org/D69008

Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since we don't have BB for libomp, time will tell. :-)

@nihui
Copy link
Contributor Author

nihui commented Apr 2, 2024

Hello, I have no commit access, please commit it for me (smile)

@shiltian shiltian merged commit c5bbdb6 into llvm:main Apr 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants