[StandardInstrumentations] Support -print-after-pass-number option #87458
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
| @@ -802,6 +807,8 @@ void PrintIRInstrumentation::printBeforePass(StringRef PassID, Any IR) { | |||
| (shouldPrintBeforePass(PassID) || shouldPrintAfterPass(PassID))) | |||
| DumpIRFilename = fetchDumpFilename(PassID, IR); | |||
|
|
|||
| ++CurrentPassNumber; | |||
There was a problem hiding this comment.
this will make pass numbers non-consecutive when we have passes we don't print IR for. is this change necessary? can you find a way to preserve the old behavior? (we should probably add a test that the pass numbers are consecutive)
There was a problem hiding this comment.
print-at-pass-number.ll does test the pass numbers are consecutive (although it doesn't test passes where the IR isn't printed). If we want to preserve the existing behavior, I can hoist the shouldPrintIR call above. The reason for hoisting incrementing CurrentPassNumber is so to have the shouldPrintAfterPass run after which is needed in the printAfterPass call.
There was a problem hiding this comment.
Moved the CurrentPassNumber back to where it was to preserve the behavior of consecutive pass numbers for printing filtered IR. I also added a test for it in the same file. The new solution is to push a new PassRunDescriptor after CurrentPassNumber has been incremented.
There was a problem hiding this comment.
Ugh nevermind, this approach doesn't work as it doesn't clean the PassRunDescriptor stack up. The new approach is to implement a separate check that only pushes the PassRunDescriptor when the you are running with -print-after-pass-number option.
|
Ping. @aeubanks I think this version should satisfy your requirements. |
| @@ -929,6 +942,11 @@ bool PrintIRInstrumentation::shouldPrintAfterPass(StringRef PassID) { | |||
| return is_contained(printAfterPasses(), PassName); | |||
| } | |||
|
|
|||
| bool PrintIRInstrumentation::shouldPrintAfterPassNumberCheck() { | |||
There was a problem hiding this comment.
shouldPrintAfterPassNumberCheck/shouldPrintAfterPassNumber is a bit confusing. perhaps shouldPrintAfter/BeforePassNumber should be shouldPrintAfter/BeforeSomePassNumber, and shouldPrintAfter/BeforePassNumberCheck should be shouldPrintAfter/BeforeCurrentPassNumber?
…ber and shouldPrintAfter/BeforePassNumberCheck->shouldPrintAfter/BeforeCurrentPassNumber
There's already support for
-print-before-pass-number, so it makes sense that we also have a-print-after-pass-number. This is especially useful if you want to print the IR after the very last pass without resorting to-print-after-alland combing through stderr or the IR file directory.