[tools] Fix LLVM_USE_SANITIZE_COVERAGE build
#87722
Conversation
justinfargnoli
changed the title
USE_SANITIZE_COVERAGE buildLLVM_USE_SANITIZE_COVERAGE build
justinfargnoli
changed the title
LLVM_USE_SANITIZE_COVERAGE buildLLVM_USE_SANITIZE_COVERAGE build
| @@ -1,5 +1,7 @@ | |||
| set(LLVM_LINK_COMPONENTS | |||
| BitReader | |||
| Core | |||
| Support | |||
There was a problem hiding this comment.
Why is this necessary? They should already be transitive deps of BitReader:
There was a problem hiding this comment.
To be frank, I don't have a strong enough understanding of the LLVM build system to properly articulate an answer.
This change was necessary to get my local build working.
My local build uses -DBUILD_SHARED_LIBS=ON. When I tested -DBUILD_SHARED_LIBS=OFF, this change was not needed to use -DLLVM_USE_SANITIZE_COVERAGE=ON.
So, perhaps the transitive dependencies are not automatically added when using -DBUILD_SHARED_LIBS=ON. Does this seem reasonable to you @nikic?
There was a problem hiding this comment.
Hm yeah, after looking at the cmake code a bit I think we make the dependencies of shared objects private.
No description provided.