Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Remove semicolons after function definitions #87764

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

NagyDonat
Copy link
Contributor

They were accidentally left behind when
#86536 converted some lambdas into stand-alone methods.

This fixes warnings from -Wc++98-compat-extra-semi

They were accidentally left behind when
llvm#86536 converted some lambdas
into stand-alone methods.

This fixes warnings from -Wc++98-compat-extra-semi
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:static analyzer labels Apr 5, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Apr 5, 2024

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-static-analyzer-1

Author: None (NagyDonat)

Changes

They were accidentally left behind when
#86536 converted some lambdas into stand-alone methods.

This fixes warnings from -Wc++98-compat-extra-semi


Full diff: https://github.com/llvm/llvm-project/pull/87764.diff

1 Files Affected:

  • (modified) clang/lib/StaticAnalyzer/Core/CallDescription.cpp (+2-2)
diff --git a/clang/lib/StaticAnalyzer/Core/CallDescription.cpp b/clang/lib/StaticAnalyzer/Core/CallDescription.cpp
index dcf6a2625b66f4..0bb0fe66e54ff8 100644
--- a/clang/lib/StaticAnalyzer/Core/CallDescription.cpp
+++ b/clang/lib/StaticAnalyzer/Core/CallDescription.cpp
@@ -89,7 +89,7 @@ bool ento::CallDescription::matchNameOnly(const NamedDecl *ND) const {
   // FIXME This comparison is way SLOWER than comparing pointers.
   // At some point in the future, we should compare FunctionDecl pointers.
   return Name.getAsString() == getFunctionName();
-};
+}
 
 bool ento::CallDescription::matchQualifiedNameParts(const Decl *D) const {
   const auto FindNextNamespaceOrRecord =
@@ -115,7 +115,7 @@ bool ento::CallDescription::matchQualifiedNameParts(const Decl *D) const {
 
   // We matched if we consumed all expected qualifier segments.
   return QualifierPartsIt == QualifierPartsEndIt;
-};
+}
 
 bool ento::CallDescription::matchesImpl(const FunctionDecl *FD, size_t ArgCount,
                                         size_t ParamCount) const {

@NagyDonat NagyDonat requested a review from Szelethus April 5, 2024 10:00
@NagyDonat NagyDonat merged commit 9a16c12 into llvm:main Apr 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:static analyzer clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants