Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT][BAT] Fix encoded NumBasicBlocks #87830

Merged
merged 8 commits into from
Apr 6, 2024

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Apr 5, 2024

Emit the recorded number of blocks, not the number of basic block
hashes. There might be differences in corner cases (openssl
BN_BLINDING_convert_ex function).

Test Plan:
Updated openssl.test in rafaelauler/bolt-tests#31

Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
@aaupov aaupov changed the base branch from users/aaupov/spr/main.boltbat-fix-encoded-numbasicblocks to main April 6, 2024 00:52
@aaupov aaupov changed the base branch from main to users/aaupov/spr/main.boltbat-fix-encoded-numbasicblocks April 6, 2024 00:52
Created using spr 1.3.4

[skip ci]
Created using spr 1.3.4
@aaupov aaupov changed the base branch from users/aaupov/spr/main.boltbat-fix-encoded-numbasicblocks to main April 6, 2024 00:53
@aaupov aaupov merged commit e64eede into main Apr 6, 2024
4 of 5 checks passed
@aaupov aaupov deleted the users/aaupov/spr/boltbat-fix-encoded-numbasicblocks branch April 6, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants