-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOLT][BAT] Fix encoded NumBasicBlocks #87830
Merged
aaupov
merged 8 commits into
main
from
users/aaupov/spr/boltbat-fix-encoded-numbasicblocks
Apr 6, 2024
Merged
[BOLT][BAT] Fix encoded NumBasicBlocks #87830
aaupov
merged 8 commits into
main
from
users/aaupov/spr/boltbat-fix-encoded-numbasicblocks
Apr 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
aaupov
requested review from
maksfb,
rafaelauler,
ayermolo and
dcci
as code owners
April 5, 2024 21:31
ayermolo
reviewed
Apr 5, 2024
Created using spr 1.3.4 [skip ci]
Created using spr 1.3.4
ayermolo
reviewed
Apr 5, 2024
Created using spr 1.3.4 [skip ci]
ayermolo
approved these changes
Apr 5, 2024
aaupov
changed the base branch from
users/aaupov/spr/main.boltbat-fix-encoded-numbasicblocks
to
main
April 6, 2024 00:52
aaupov
changed the base branch from
main
to
users/aaupov/spr/main.boltbat-fix-encoded-numbasicblocks
April 6, 2024 00:52
Created using spr 1.3.4 [skip ci]
aaupov
changed the base branch from
users/aaupov/spr/main.boltbat-fix-encoded-numbasicblocks
to
main
April 6, 2024 00:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit the recorded number of blocks, not the number of basic block
hashes. There might be differences in corner cases (openssl
BN_BLINDING_convert_ex function).
Test Plan:
Updated openssl.test in rafaelauler/bolt-tests#31