[lld] Error on unsupported split stack

[patrick-rivos]

Targets with no -fstack-split support now emit ld.lld: error: target doesn't support split stacks instead of UNREACHABLE executed with a backtrace asking the user to report a bug.

Resolves #88061

[llvmbot]

@llvm/pr-subscribers-lld-elf

Author: Patrick O'Neill (patrick-rivos)

Changes

Targets with no -fstack-split support now emit ld.lld: error: Target doesn't support split stacks. instead of UNREACHABLE executed with a backtrace asking the user to report a bug.

Resolves #88061

---

Full diff: https://github.com/llvm/llvm-project/pull/88063.diff

1 Files Affected:

• (modified) lld/ELF/Target.cpp (+1-1)

diff --git a/lld/ELF/Target.cpp b/lld/ELF/Target.cpp
index d879a427e9c096..735b2a82d851b4 100644
--- a/lld/ELF/Target.cpp
+++ b/lld/ELF/Target.cpp
@@ -141,7 +141,7 @@ bool TargetInfo::needsThunk(RelExpr expr, RelType type, const InputFile *file,
 
 bool TargetInfo::adjustPrologueForCrossSplitStack(uint8_t *loc, uint8_t *end,
                                                   uint8_t stOther) const {
-  llvm_unreachable("Target doesn't support split stacks.");
+  fatal("Target doesn't support split stacks.");
 }
 
 bool TargetInfo::inBranchRange(RelType type, uint64_t src, uint64_t dst) const {

[llvmbot]

@llvm/pr-subscribers-lld

Author: Patrick O'Neill (patrick-rivos)

Changes

Targets with no -fstack-split support now emit ld.lld: error: Target doesn't support split stacks. instead of UNREACHABLE executed with a backtrace asking the user to report a bug.

Resolves #88061

---

Full diff: https://github.com/llvm/llvm-project/pull/88063.diff

1 Files Affected:

• (modified) lld/ELF/Target.cpp (+1-1)

diff --git a/lld/ELF/Target.cpp b/lld/ELF/Target.cpp
index d879a427e9c096..735b2a82d851b4 100644
--- a/lld/ELF/Target.cpp
+++ b/lld/ELF/Target.cpp
@@ -141,7 +141,7 @@ bool TargetInfo::needsThunk(RelExpr expr, RelType type, const InputFile *file,
 
 bool TargetInfo::adjustPrologueForCrossSplitStack(uint8_t *loc, uint8_t *end,
                                                   uint8_t stOther) const {
-  llvm_unreachable("Target doesn't support split stacks.");
+  fatal("Target doesn't support split stacks.");
 }
 
 bool TargetInfo::inBranchRange(RelType type, uint64_t src, uint64_t dst) const {

[github-actions]

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

[MaskRay]

Test?

[patrick-rivos]

Will do - I'm not familiar with stack splitting/how to write a concise testcase that triggers it so it might take me some time.

[patrick-rivos]

Added testcase and force-pushed to get rid of the github email address from the commit.

[patrick-rivos]

Ping.

[patrick-rivos]

Thanks for the review!
I don't have write permission. Could you land these changes for me?