[lld][ELF] Implement merged .debug_names section #88092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaskRay
force-pushed
the
lld-debug-names
branch
12 times, most recently
from
ef4ffb2
to
4ad3c21
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
MaskRay
force-pushed
the
lld-debug-names
branch
17 times, most recently
from
d0df4bc
to
17be909
Compare
MaskRay
force-pushed
the
lld-debug-names
branch
12 times, most recently
from
c25269f
to
31da662
Compare
Add Inputs/debug-names-[ab].s which can be easily regenerated Update some negative tests to use Inputs/debug-names-[ab].s or apply straightforward transformation with sed
MaskRay
force-pushed
the
lld-debug-names
branch
from
31da662
to
d12762c
Compare
- Update comment about CompUnits in OutputChunk. - Replace two uses of 'seq' in for-loops. - Replace use of memcpy with llvm::copy.
Fix typo, add 'const', replace one use of 'seq'/
- Keep type unit counts in output header at zero, regardless of input, to avoid crashing LLD, since we're not actually handling type units yet. - Move the type units warning to the point where we can check the input counts. - Add a type units test (that LLD doesn't crash and outputs the warning).
Remove tools/generate-content.py. We will use a generic tool intended for llvm/utils: https://discourse.llvm.org/t/utility-to-generate-elaborated-assembly-ir-tests/78408
Remove tools/generate-content.py. We will use a generic tool intended for llvm/utils: https://discourse.llvm.org/t/utility-to-generate-elaborated-assembly-ir-tests/78408
MaskRay
force-pushed
the
lld-debug-names
branch
from
ac233d4
to
232c729
Compare
- Pulled body of loop that reads/parses IndexEntries into a separate function (readEntry) - Removed unnecessary 'const' qualifiers on local vars - Updated comment about handling type units - Created getChunks accessor function; used it to eliminate use of 'seq' in for-loop. - Enhanced some error messages - Update debug-names-bad.s test to handle udpated error messages
- Clean up the error messages in readEntry function - Restore 'const' qualifier to size_t vars in computeEntryPool - Add 'const' qualifier to getChunks function.
MaskRay
force-pushed
the
lld-debug-names
branch
2 times, most recently
from
257fb79
to
7b119cf
Compare
MaskRay
force-pushed
the
lld-debug-names
branch
from
7b119cf
to
69870a5
Compare
|
Everything has been merged into #86508 , which landed yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.