[emacs] Handle vector types, arbitary integer types and function names #88246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resurrecting this patch from https://reviews.llvm.org/D158321 This adds a few more regexp patterns for llvm-mode-syntax-table. The primitive type regexp was split out so it could be reused when handling vectors. Also worth noting is that the vector regexp needs to come before the primitive types, otherwise they will match first. @goldsteinn I was able to address your review comments, turns out you can set a font-face for a specific match group. And < 2x i64> should be accepted now.
lukel97
force-pushed
the
llvm-mode-font-lock-improvements
branch
from
18e2504
to
ff6734d
Compare
|
Gentle ping |
|
Bah sorry, didn't have "@" mentions configured correctly for a while now.... This LGTM. Thank you! |
|
No worries, thanks for taking a look! |
clayborg
pushed a commit
to clayborg/llvm-project
that referenced
this pull request
Jun 20, 2024
llvm#88246) Resurrecting this patch from https://reviews.llvm.org/D158321 This adds a few more regexp patterns for llvm-mode-syntax-table. The primitive type regexp was split out so it could be reused when handling vectors. Also worth noting is that the vector regexp needs to come before the primitive types, otherwise they will match first.
|
loving this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrecting this patch from https://reviews.llvm.org/D158321
This adds a few more regexp patterns for llvm-mode-syntax-table. The primitive type regexp was split out so it could be reused when handling vectors. Also worth noting is that the vector regexp needs to come before the primitive types, otherwise they will match first.
@goldsteinn I was able to address your review comments, turns out you can set a font-face for a specific match group. And < 2x i64> should be accepted now.