Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP][AIX] Fix test config for AIX #88272

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

xingxue-ibm
Copy link
Contributor

This patch fixes the test config so that it works for tasking/omp50_taskdep_depobj.c which uses different flags to test with compiler's omp.h.

  • set test environment variable OBJECT_MODE to 64 if it is set explicitly to 64 in the AIX environment. OBJECT_MODE is default to 32 and is recognized by AIX compilers and toolchain. In this way, we don't need to set -m64 for all compiler flags for 64-bit mode
  • add option -Wl,-bmaxdata to 32-bit test_openmp_flags used by tasking/omp50_taskdep_depobj.c

@xingxue-ibm xingxue-ibm added the openmp:libomp OpenMP host runtime label Apr 10, 2024
@xingxue-ibm xingxue-ibm requested a review from kkwli April 10, 2024 14:22
@xingxue-ibm xingxue-ibm self-assigned this Apr 10, 2024
Copy link
Collaborator

@kkwli kkwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks.

@xingxue-ibm xingxue-ibm merged commit b3792ae into llvm:main Apr 10, 2024
6 checks passed
@xingxue-ibm xingxue-ibm deleted the test-cfg branch May 24, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants