Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm-mca] Remove spurious include_directories() #88277

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

RoboTux
Copy link
Contributor

@RoboTux RoboTux commented Apr 10, 2024

llvm-mca does not have an include directory so this commit removes the
spurious include_directories directive.

llvm-mca does not have an include directory so this commit removes the
spurious include_directories directive.
@llvmbot
Copy link
Collaborator

llvmbot commented Apr 10, 2024

@llvm/pr-subscribers-tools-llvm-mca

Author: Thomas Preud'homme (RoboTux)

Changes

llvm-mca does not have an include directory so this commit removes the
spurious include_directories directive.


Full diff: https://github.com/llvm/llvm-project/pull/88277.diff

1 Files Affected:

  • (modified) llvm/tools/llvm-mca/CMakeLists.txt (-2)
diff --git a/llvm/tools/llvm-mca/CMakeLists.txt b/llvm/tools/llvm-mca/CMakeLists.txt
index 878a05c51cfb47..4ef8b9afa12a7a 100644
--- a/llvm/tools/llvm-mca/CMakeLists.txt
+++ b/llvm/tools/llvm-mca/CMakeLists.txt
@@ -1,5 +1,3 @@
-include_directories(include)
-
 set(LLVM_LINK_COMPONENTS
   AllTargetsAsmParsers
   AllTargetsMCAs          # CustomBehaviour and InstrPostProcess

Copy link
Member

@mshockwave mshockwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM good catch, thanks!

Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@holland11 holland11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RoboTux RoboTux merged commit 82ae646 into llvm:main Apr 11, 2024
5 of 6 checks passed
@RoboTux RoboTux deleted the remove_spurious_include_directories branch April 18, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants