[Support] Fix the issue where the character being saved in Unicode causes a warning to be treated as an error in Visual Studio 2022.

[TSWorld1314]

Fix the issue where the character being saved in Unicode causes a warning to be treated as an error in Visual Studio 2022.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-llvm-support

Author: Harrison,Hao (TSWorld1314)

Changes

Fix the issue where the character being saved in Unicode causes a warning to be treated as an error in Visual Studio 2022.

---

Full diff: https://github.com/llvm/llvm-project/pull/88513.diff

1 Files Affected:

• (modified) llvm/lib/Support/Parallel.cpp (+1-1)

diff --git a/llvm/lib/Support/Parallel.cpp b/llvm/lib/Support/Parallel.cpp
index 9b14b05b521160..fe7834c86e3d0e 100644
--- a/llvm/lib/Support/Parallel.cpp
+++ b/llvm/lib/Support/Parallel.cpp
@@ -57,7 +57,7 @@ class ThreadPoolExecutor : public Executor {
     Threads.resize(1);
     std::lock_guard<std::mutex> Lock(Mutex);
     // Use operator[] before creating the thread to avoid data race in .size()
-    // in “safe libc++” mode.
+    // in "safe libc++" mode.
     auto &Thread0 = Threads[0];
     Thread0 = std::thread([this, S] {
       for (unsigned I = 1; I < ThreadCount; ++I) {

[jhuber6]

Can you add the relevant error message you're getting to the PR's description please.

[jhuber6]

Suggested change

	// in "safe libc++" mode.
	// in 'safe libc++' mode.

Single quotes are more common for stuff like this.

[jhuber6]

Is this really all it takes for VSC to fail? It's just a comment, so I would assume it's not an issue.

[TSWorld1314]

[github-actions]

@TSWorld1314 Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!