[flang][test] Detect OpenMP runtime when built via LLVM_RUNTIMES_TO_B… #88914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UILD The lit config was checking for the presence of the OpenMP runtime by looking at LLVM_TOOL_OPENMP_BUILD. This only works when the runtime is enabled in LLVM_PROJECTS_TO_BUILD. Expand the check to examine LLVM_RUNTIMES_TO_BUILD as well.
kiranchandramohan
approved these changes
Apr 16, 2024
|
There has been some duplication of work here, sorry. I'm close to finishing up a PR that solves this problem for all runtimes. I'd suggest to use the more general one instead. The PR is: #88934. |
|
Plus, once #88934 has been landed, we can use the new CMake variable to detect the presence of OpenMP as a runtime in the tests. |
|
Closing. To be replaced with Michael's PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…UILD
The lit config was checking for the presence of the OpenMP runtime by looking at LLVM_TOOL_OPENMP_BUILD. This only works when the runtime is enabled in LLVM_PROJECTS_TO_BUILD. Expand the check to examine LLVM_RUNTIMES_TO_BUILD as well.