Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MachineOutliner] Sort Outlining Functions by Priority #88990

Closed

Conversation

xuanzhang816
Copy link
Contributor

We changed the order in which functions are outlined in Machine Outliner.

In MachineOutliner::outline(), functions are sorted by their benefits first and then outlined one at a time greedily. Our investigation shows that sorting the functions by a different value, which we call priority, could be more beneficial. For clang, sorting the functions by priority reduces the binary size by 1.8% compared to the baseline; if we additionally consider leaf descendants to include more candidates, the binary size is reduced by 2.8% compared to the baseline.

The formula for priority is found via a black-box Bayesian optimization toolbox, and we have shown that using this formula for sorting consistently reduces uncompressed mobile app size within our company.

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant