Fix uninitialized variable

[iagarwa]

Fix uninitialized scalar field

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-backend-directx

Author: Isha Agarwal (iagarwa)

Changes

Fix uninitialized scalar field

---

Full diff: https://github.com/llvm/llvm-project/pull/89040.diff

1 Files Affected:

• (modified) llvm/include/llvm/BinaryFormat/DXContainer.h (+1-1)

diff --git a/llvm/include/llvm/BinaryFormat/DXContainer.h b/llvm/include/llvm/BinaryFormat/DXContainer.h
index e8d03f806715f1..7ef858d0b393b6 100644
--- a/llvm/include/llvm/BinaryFormat/DXContainer.h
+++ b/llvm/include/llvm/BinaryFormat/DXContainer.h
@@ -427,7 +427,7 @@ struct ResourceBindInfo : public v0::ResourceBindInfo {
 
 namespace v3 {
 struct RuntimeInfo : public v2::RuntimeInfo {
-  uint32_t EntryNameOffset;
+  uint32_t EntryNameOffset = 0;
 
   void swapBytes() {
     v2::RuntimeInfo::swapBytes();

[llvmbot]

@llvm/pr-subscribers-llvm-binary-utilities

Author: Isha Agarwal (iagarwa)

Changes

Fix uninitialized scalar field

---

Full diff: https://github.com/llvm/llvm-project/pull/89040.diff

1 Files Affected:

• (modified) llvm/include/llvm/BinaryFormat/DXContainer.h (+1-1)

diff --git a/llvm/include/llvm/BinaryFormat/DXContainer.h b/llvm/include/llvm/BinaryFormat/DXContainer.h
index e8d03f806715f1..7ef858d0b393b6 100644
--- a/llvm/include/llvm/BinaryFormat/DXContainer.h
+++ b/llvm/include/llvm/BinaryFormat/DXContainer.h
@@ -427,7 +427,7 @@ struct ResourceBindInfo : public v0::ResourceBindInfo {
 
 namespace v3 {
 struct RuntimeInfo : public v2::RuntimeInfo {
-  uint32_t EntryNameOffset;
+  uint32_t EntryNameOffset = 0;
 
   void swapBytes() {
     v2::RuntimeInfo::swapBytes();

[iagarwa]

@MalaySanghi @mahesh-attarde please review

[llvm-beanz]

Uh, why do we need to do this? None of the other data structures in this file initialize their values with inline initializers.

[iagarwa]

RuntimeInfo Objects are created only for v3 ones. That's why i initialize only EntryNameOffset

[llvm-beanz]

Even if that were true (which it isn’t, we create a std::variant of the four versions), the change still doesn’t make sense. Why would we want to only initialize the last field of a large data structure?

Is there an actual case where this caused an uninitialized value to be used, or is this just a speculative problem?

[MalaySanghi]

@iagarwa
The field is initialized before use. Just not in the constructor. Look at PSVRuntimeInfo::finalize. So it seems to me that there's no bug.

Although I don't see a downside in initializing the field, I think you can ignore this.

[iagarwa]

Not needed