Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm-rc: add support for MENU in DIALOG(EX) #89409

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

oltolm
Copy link
Contributor

@oltolm oltolm commented Apr 19, 2024

Adds support for MENU in DIALOG(EX) to llvm-rc. Fixes #49559.

@oltolm
Copy link
Contributor Author

oltolm commented Apr 25, 2024

@mstorsjo Sorry, can I ask you for review?

@mstorsjo mstorsjo self-requested a review April 25, 2024 19:41
@mstorsjo
Copy link
Member

@mstorsjo Sorry, can I ask you for review?

Sure, I'll try to get around to it in a while

Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks mostly reasonable! I just have one inline question.

llvm/tools/llvm-rc/ResourceScriptParser.cpp Outdated Show resolved Hide resolved
Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now, thanks!

@mstorsjo mstorsjo merged commit b35bdb1 into llvm:main Apr 29, 2024
3 of 4 checks passed
@oltolm oltolm deleted the dialog-with-menu branch April 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm-rc doesn't support MENU entries in DIALOGEX resource declaration
2 participants