Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlir] Update comment about propertiesAttr (NFC) #89633

Closed
wants to merge 3 commits into from
Closed

[mlir] Update comment about propertiesAttr (NFC) #89633

wants to merge 3 commits into from

Commits on Apr 22, 2024

  1. [mlir][ods] Allow sharding of op definitions 

    Adds an option to `mlir-tblgen -gen-op-defs` `op-shard-count=N` that divides the
op class definitions and op list into N segments, e.g.

```
// mlir-tblgen -gen-op-defs -op-shard-count=2

void FooDialect::initialize() {
  addOperations<
  >();
  addOperations<
  >();
}

```

When split across multiple source files, this can help significantly improve
dialect compile time for dialects with a large opset.

stack-info: PR: #89423, branch: users/mogball/pr_1
    @Mogball
    Mogball committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    caff32b View commit details
    Browse the repository at this point in the history

  2. [mlir][test] Reorganize the test dialect 

    This PR massively reorganizes the Test dialect's source files. It moves
manually-written op hooks into `TestOpDefs.cpp`, moves format custom
directive parsers and printers into `TestFormatUtils`, adds missing
comment blocks, and moves around where generated source files are
included for types, attributes, enums, etc. into their own source file.

This will hopefully help navigate the test dialect source code, but also
speeds up compile time of the test dialect by putting generated source
files into separate compilation units.

This also sets up the test dialect to shard its op definitions, done in
the next PR.

stack-info: PR: #89424, branch: users/mogball/pr_2
    @Mogball
    Mogball committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c03dd33 View commit details
    Browse the repository at this point in the history

  3. [mlir][test] Shard the Test Dialect (NFC) 

    This PR uses the new op sharding mechanism in tablegen to shard the test
dialect's op definitions. This breaks the definition of ops into
multiple source files, speeding up compile time of the test dialect
dramatically. This improves developer cycle times when iterating on the
test dialect.

stack-info: PR: #89628, branch: users/Mogball/stack/1
    @Mogball
    Mogball committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    478b4e8 View commit details
    Browse the repository at this point in the history