[PowerPC][NFC] Allow different orders of .extern in some test cases

[orcguru]

The order of .externs is irrelevant to the functionality, however reverse-iteration buildbot check that.

[llvmbot]

@llvm/pr-subscribers-backend-powerpc

Author: Felix (Ting Wang) (orcguru)

Changes

The order of .externs is irrelevant to the functionality, however reverse-iteration buildbot check that.

---

Full diff: https://github.com/llvm/llvm-project/pull/89714.diff

3 Files Affected:

• (modified) llvm/test/CodeGen/PowerPC/aix-tls-gd-double.ll (+8-8)
• (modified) llvm/test/CodeGen/PowerPC/aix-tls-gd-int.ll (+8-8)
• (modified) llvm/test/CodeGen/PowerPC/aix-tls-gd-longlong.ll (+8-8)

diff --git a/llvm/test/CodeGen/PowerPC/aix-tls-gd-double.ll b/llvm/test/CodeGen/PowerPC/aix-tls-gd-double.ll
index ae41b6b1301064..196c4a6e743f78 100644
--- a/llvm/test/CodeGen/PowerPC/aix-tls-gd-double.ll
+++ b/llvm/test/CodeGen/PowerPC/aix-tls-gd-double.ll
@@ -612,14 +612,14 @@ entry:
 
 ; External symbol reference checks for .__tls_get_addr/.__tls_get_mod
 
-; SMALL32: .extern .__tls_get_addr[PR]
-; SMALL32: .extern .__tls_get_mod[PR]
-; SMALL64: .extern .__tls_get_addr[PR]
-; SMALL64: .extern .__tls_get_mod[PR]
-; LARGE32: .extern .__tls_get_addr[PR]
-; LARGE32: .extern .__tls_get_mod[PR]
-; LARGE64: .extern .__tls_get_addr[PR]
-; LARGE64: .extern .__tls_get_mod[PR]
+; SMALL32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; SMALL32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; SMALL64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; SMALL64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
 
 ; TOC entry checks
 
diff --git a/llvm/test/CodeGen/PowerPC/aix-tls-gd-int.ll b/llvm/test/CodeGen/PowerPC/aix-tls-gd-int.ll
index bbb8e04b67b95e..6814dbe9e457a8 100644
--- a/llvm/test/CodeGen/PowerPC/aix-tls-gd-int.ll
+++ b/llvm/test/CodeGen/PowerPC/aix-tls-gd-int.ll
@@ -627,14 +627,14 @@ entry:
 
 ; External symbol reference checks for .__tls_get_addr/.__tls_get_mod
 
-; SMALL32: .extern .__tls_get_addr[PR]
-; SMALL32: .extern .__tls_get_mod[PR]
-; SMALL64: .extern .__tls_get_addr[PR]
-; SMALL64: .extern .__tls_get_mod[PR]
-; LARGE32: .extern .__tls_get_addr[PR]
-; LARGE32: .extern .__tls_get_mod[PR]
-; LARGE64: .extern .__tls_get_addr[PR]
-; LARGE64: .extern .__tls_get_mod[PR]
+; SMALL32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; SMALL32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; SMALL64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; SMALL64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
 
 ; TOC entry checks
 
diff --git a/llvm/test/CodeGen/PowerPC/aix-tls-gd-longlong.ll b/llvm/test/CodeGen/PowerPC/aix-tls-gd-longlong.ll
index ff087a2144488c..54d954125b4cda 100644
--- a/llvm/test/CodeGen/PowerPC/aix-tls-gd-longlong.ll
+++ b/llvm/test/CodeGen/PowerPC/aix-tls-gd-longlong.ll
@@ -667,14 +667,14 @@ entry:
 
 ; External symbol reference checks for .__tls_get_addr/.__tls_get_mod
 
-; SMALL32: .extern .__tls_get_addr[PR]
-; SMALL32: .extern .__tls_get_mod[PR]
-; SMALL64: .extern .__tls_get_addr[PR]
-; SMALL64: .extern .__tls_get_mod[PR]
-; LARGE32: .extern .__tls_get_addr[PR]
-; LARGE32: .extern .__tls_get_mod[PR]
-; LARGE64: .extern .__tls_get_addr[PR]
-; LARGE64: .extern .__tls_get_mod[PR]
+; SMALL32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; SMALL32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; SMALL64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; SMALL64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE32: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
+; LARGE64: .extern .{{__tls_get_addr|__tls_get_mod}}[PR]
 
 ; TOC entry checks
 

[chenzheng1030]

Could you please explain why the order changes with/without your change about supporting local dynamic TLS mode? Thanks very much.

[orcguru]

Before the LD patch there is only .__tls_get_addr[PR]
After the LD patch, there is .__tls_get_addr[PR] and .__tls_get_mod[PR]

The LD patch turned some variables from GD to LD, so created new extern

[chenzheng1030]

OK. One more question is do we know why TLS external function calls are impacted by the iteration order, while for below cases:

int foo();
int bar();

int test() {
  return foo() + bar();
}

The external foo() and bar() are the same with both iteration order.

Could you please help to figure that out? And yes, like @efriedma-quic said, we may need to fix this in the compiler, not the test case.

Thanks a lot.

[efriedma-quic]

We actually care that the output of the compiler is deterministic, not just that the tests pass. This is important for reproducible builds.

So I don't think changing the CHECK lines is right here. Probably the compiler should sort the symbols before it outputs them, or something like that.

[orcguru]

Sure, let me dig out the root cause, and hope somebody can fix that.

ExtSymSDNodeSymbols
It's definition was: SmallPtrSet<MCSymbol *, 8> ExtSymSDNodeSymbols;

Basically that's why we saw the reorder.

[chenzheng1030]

To let the community be aware, @bzEq will take over this issue. Thanks very much Kai. And thank you for addressing the root cause @orcguru