[BOLT] Emit synthetic FILE symbol for local cold fragments of global symbols #89794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to llvm#89648. Emit a FILE symbol to distinguish BOLT-created local symbols for split functions, to prevent polluting the namespace of the last file symbol. Test Plan: Updated cdsplit-symbol-names.s
aaupov
requested review from
maksfb,
rafaelauler,
ayermolo and
dcci
as code owners
aaupov
changed the title
dcci
reviewed
Apr 24, 2024
maksfb
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #89648.
Emit a FILE symbol to distinguish BOLT-created local symbols for cold
fragments of global split functions, to prevent polluting the namespace
of the last file symbol.
This eliminates the possibility of emitting the fragment under the file
that already contains the parent and fragment with the same name, which
can break cold fragment parent lookup in
registerFragment.This issue is more probable with LTO binaries where many symbols are
emitted under
ld-temp.o.Test Plan: Updated cdsplit-symbol-names.s