Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT,RISCV] Remove empty name special case from #68977 #90004

Conversation

MaskRay
Copy link
Member

@MaskRay MaskRay commented Apr 24, 2024

The special case is unneeded after #89693.

Created using spr 1.3.5-bogner
@maksfb
Copy link
Contributor

maksfb commented Apr 25, 2024

Do we need to handle this special case to keep compatibility with older toolchains?

@MaskRay
Copy link
Member Author

MaskRay commented Apr 25, 2024

Do we need to handle this special case to keep compatibility with older toolchains?

BOLT's RISC-V port is pretty new. I hope that we don't keep such compatibility (old clang with new bolt)...

@maksfb
Copy link
Contributor

maksfb commented Apr 25, 2024

I'm fine with removing the special case as long as @mtvec agrees.

Copy link
Contributor

@mtvec mtvec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MaskRay
Copy link
Member Author

MaskRay commented Apr 25, 2024

The premerge bot fails.

The reason is that %clang in bolt/test/RISCV/fake-label-no-entry.c expands to /usr/bin/clang instead of the just-built clang.

@aaupov
Copy link
Contributor

aaupov commented Apr 26, 2024

The premerge bot fails.

The reason is that %clang in bolt/test/RISCV/fake-label-no-entry.c expands to /usr/bin/clang instead of the just-built clang.

Let me look into that. It was done intentionally to reduce pre-merge builder load, but looks like there's no way around using trunk clang in BOLT testing.

@aaupov
Copy link
Contributor

aaupov commented Apr 26, 2024

Should be fixed by 59bfc31

@MaskRay
Copy link
Member Author

MaskRay commented Apr 26, 2024

Should be fixed by 59bfc31

Thanks!

@MaskRay MaskRay merged commit e982032 into main Apr 26, 2024
4 of 5 checks passed
@MaskRay MaskRay deleted the users/MaskRay/spr/boltriscv-remove-empty-name-special-case-from-68977 branch April 26, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants