Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Do not set CMP0114 explicitly to old #90384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CMake] Do not set CMP0114 explicitly to old #90384

wants to merge 1 commit into from
+0 −5

Commits on Apr 28, 2024

  1. [CMake] Do not set CMP0114 explicitly to old 

    CMP0114 was originally set to old to get rid of warnings. However, this
behavior is now set to new by default with the minimum CMake version
that LLVM requires so does not produce any warnings,
and setting it explicitly to old does produce a warning in newer CMake
versions. Due to these reasons, remove this check for now.

Splitting off from removing the CMP0116 check just in case something
breaks.

Partially fixes llvm#83727.
    @boomanaiden154
    boomanaiden154 committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    e477a6d View commit details
    Browse the repository at this point in the history