[libc++] Restore __synth_three_way lambda
#90398
Draft
+11
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
H-G-Hristov
force-pushed
the
hgh/libcxx/__synth_three_way-restore-the-lambda-to-match-the-Standard
branch
from
df28d44
to
af02e09
Compare
|
Not possible yet. We'll need an Xcode based on LLVM 17. |
H-G-Hristov
force-pushed
the
hgh/libcxx/__synth_three_way-restore-the-lambda-to-match-the-Standard
branch
from
af02e09
to
a7522dd
Compare
…bda-to-match-the-Standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore
__synth_three_waylambda to match the Standard.GH-57222 is done, restoring the Standard wording implementation should be possible.
https://github.com/llvm/llvm-project/blob/df28d4412c1d21b0e18896c92ac77d2fac7729f1/libcxx/include/__compare/synth_three_way.h#L28
According to comment #59513 (comment), GH-59513 is not a blocker.