Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[X86] Enable EVEX512 when host CPU has AVX512 #90479

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

phoebewang
Copy link
Contributor

This is used when -march=native run on an unknown CPU to old version of LLVM.

This is used when -march=native is not a known CPU to LLVM old version.
Copy link

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 8d5386669ed63548daf1bee415596582d6d78d7d 9e84562bbea4d733199bef8d760c8e7a02bdb941 -- llvm/lib/TargetParser/Host.cpp
View the diff from clang-format here.
diff --git a/llvm/lib/TargetParser/Host.cpp b/llvm/lib/TargetParser/Host.cpp
index e911d15498..c71adadbb7 100644
--- a/llvm/lib/TargetParser/Host.cpp
+++ b/llvm/lib/TargetParser/Host.cpp
@@ -1801,7 +1801,7 @@ bool sys::getHostCPUFeatures(StringMap<bool> &Features) {
   Features["rtm"]        = HasLeaf7 && ((EBX >> 11) & 1);
   // AVX512 is only supported if the OS supports the context save for it.
   Features["avx512f"]    = HasLeaf7 && ((EBX >> 16) & 1) && HasAVX512Save;
-  Features["evex512"]    = Features["avx512f"];
+  Features["evex512"] = Features["avx512f"];
   Features["avx512dq"]   = HasLeaf7 && ((EBX >> 17) & 1) && HasAVX512Save;
   Features["rdseed"]     = HasLeaf7 && ((EBX >> 18) & 1);
   Features["adx"]        = HasLeaf7 && ((EBX >> 19) & 1);

Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phoebewang phoebewang merged commit b329179 into llvm:main Apr 30, 2024
4 of 5 checks passed
@phoebewang phoebewang deleted the evex512 branch April 30, 2024 02:09
@phoebewang
Copy link
Contributor Author

cherry-pick b329179

@phoebewang phoebewang added this to the LLVM 18.X Release milestone Apr 30, 2024
@nikic
Copy link
Contributor

nikic commented Apr 30, 2024

/cherry-pick b329179

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Apr 30, 2024
This is used when -march=native run on an unknown CPU to old version of
LLVM.

(cherry picked from commit b329179)
@llvmbot
Copy link
Collaborator

llvmbot commented Apr 30, 2024

/pull-request #90545

tstellar pushed a commit to llvmbot/llvm-project that referenced this pull request May 1, 2024
This is used when -march=native run on an unknown CPU to old version of
LLVM.

(cherry picked from commit b329179)
@pointhex pointhex mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants