Remove redundant move in return statement #90546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joker-eph , can you please help me review this pull request? Thank you! |
joker-eph
approved these changes
Apr 30, 2024
|
I don't have permission to merge this pull request. @joker-eph could you please help me merge it? Thank you! |
|
Windows pre merge failure was broken at head and is unrelated, I’ll merge |
joker-eph
added a commit
that referenced
this pull request
May 6, 2024
Reverts #90546 This broke some bots, seems like some toolchain don’t consider the implicit move here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes unnecessary move in the return statement to suppress compilation warnings.