[lldb] Always emit diagnostic events to the system log #90913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) ChangesAlways emit diagnostic events to the system log so that they end up in the sysdiagnose on Darwin. Full diff: https://github.com/llvm/llvm-project/pull/90913.diff 1 Files Affected:
diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp
index cac4642873b772..c5ab99fac75d27 100644
--- a/lldb/source/Core/Debugger.cpp
+++ b/lldb/source/Core/Debugger.cpp
@@ -1512,7 +1512,22 @@ void Debugger::ReportDiagnosticImpl(DiagnosticEventData::Type type,
std::string message,
std::optional<lldb::user_id_t> debugger_id,
std::once_flag *once) {
+ auto GetSystemLogLevel = [](DiagnosticEventData::Type type) {
+ switch (type) {
+ case DiagnosticEventData::Type::Info:
+ return Host::eSystemLogInfo;
+ case DiagnosticEventData::Type::Warning:
+ return Host::eSystemLogWarning;
+ case DiagnosticEventData::Type::Error:
+ return Host::eSystemLogError;
+ }
+ llvm_unreachable("All cases handled above!");
+ };
+
auto ReportDiagnosticLambda = [&]() {
+ // Always log diagnostics to the system log.
+ Host::SystemLog(GetSystemLogLevel(type), message);
+
// The diagnostic subsystem is optional but we still want to broadcast
// events when it's disabled.
if (Diagnostics::Enabled())
|
medismailben
approved these changes
May 2, 2024
lldb/source/Core/Debugger.cpp
Outdated
| @@ -1512,7 +1512,22 @@ void Debugger::ReportDiagnosticImpl(DiagnosticEventData::Type type, | |||
| std::string message, | |||
| std::optional<lldb::user_id_t> debugger_id, | |||
| std::once_flag *once) { | |||
| auto GetSystemLogLevel = [](DiagnosticEventData::Type type) { | |||
There was a problem hiding this comment.
nit: This could be constexpr I think
adrian-prantl
approved these changes
May 2, 2024
Always emit diagnostic events to the system log so that they end up in the sysdiagnose on Darwin.
JDevlieghere
force-pushed
the
log-diagnostics-to-system-log
branch
from
4589130
to
7ed4008
Compare
JDevlieghere
added a commit
to apple/llvm-project
that referenced
this pull request
May 3, 2024
Always emit diagnostic events to the system log so that they end up in the sysdiagnose on Darwin. (cherry picked from commit f9d91fb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always emit diagnostic events to the system log so that they end up in the sysdiagnose on Darwin.