[DirectX] Remove unneccary check lines #90979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These check lines break as of 91446e2 due to changes in how LLVM handles debug information. Since debug informaiton isn't important to what this test is verifying we can remove the check lines.
damyanp
approved these changes
May 3, 2024
python3kgae
approved these changes
May 3, 2024
python3kgae
reviewed
May 3, 2024
| ; CHECK: Function Attrs: nounwind memory(none) | ||
| ; Function Attrs: nofree nosync nounwind readnone speculatable willreturn | ||
| declare void @llvm.dbg.value(metadata, metadata, metadata) #1 | ||
|
|
There was a problem hiding this comment.
Should we remove the attributes #1 = { nofree nosync nounwind readnone speculatable willreturn } since it is not used anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These check lines break as of 91446e2 due to changes in how LLVM handles debug information. Since debug informaiton isn't important to what this test is verifying we can remove the check lines.