[CMake] Add INTERFACE_INCLUDE_DIRECTORIES property to add_llvm_library macro #90991
Conversation
…y macro As mentioned in issue llvm#53568, the current directions for using LLVM libraries in other projects, requiring ``` include_directories(${LLVM_INCLUDE_DIRS}) ``` shouldn't be necessary. This adds `INCLUDES DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"` to the `add_llvm_library` macro in `AddLLVM.cmake`. We may also want to add this to `add_clang_library` and other places, but I'm not familiar with the full details of LLVM's cmake setup either, so I'd appreciate feedback on this as a draft.
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
Ping |
As mentioned in issue #53568, the current directions for using LLVM libraries in other projects, requiring
shouldn't be necessary. This adds
INCLUDES DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}"to theadd_llvm_librarymacro inAddLLVM.cmake.We may also want to add this to
add_clang_libraryand other places, but I'm not familiar with the full details of LLVM's cmake setup either, so I'd appreciate feedback on this as a draft.