Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Fix missing GITHUB_TOKEN in release-doxygen.yml upload step #91091

Merged
merged 1 commit into from
May 10, 2024

Conversation

tstellar
Copy link
Collaborator

@tstellar tstellar commented May 4, 2024

We were accidentally setting the GITHUB_TOKEN environment variable in the previous step.

We were accidentally setting the GITHUB_TOKEN environment variable in the
previous step.
@llvmbot
Copy link
Collaborator

llvmbot commented May 4, 2024

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

We were accidentally setting the GITHUB_TOKEN environment variable in the previous step.


Full diff: https://github.com/llvm/llvm-project/pull/91091.diff

1 Files Affected:

  • (modified) .github/workflows/release-doxygen.yml (+2-2)
diff --git a/.github/workflows/release-doxygen.yml b/.github/workflows/release-doxygen.yml
index 5e322849a1d093..12c14bea52f624 100644
--- a/.github/workflows/release-doxygen.yml
+++ b/.github/workflows/release-doxygen.yml
@@ -56,12 +56,12 @@ jobs:
           pip3 install --user -r ./llvm/docs/requirements.txt
 
       - name: Build Doxygen
-        env:
-          GITHUB_TOKEN: ${{ github.token }}
         run: |
           ./llvm/utils/release/build-docs.sh -release "${{ inputs.release-version }}" -no-sphinx
 
       - name: Upload Doxygen
         if: env.upload
+        env:
+          GITHUB_TOKEN: ${{ github.token }}
         run: |
           ./llvm/utils/release/github-upload-release.py --token "$GITHUB_TOKEN" --release "${{ inputs.release-version }}" --user "${{ github.actor }}" upload --files ./*doxygen*.tar.xz

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I can't think of an easy way to catch this sort of thing without just actually running it as part of the release process.

@tstellar tstellar merged commit 720dfd9 into llvm:main May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants