-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lldb create API folder if it does not exist, before creating SBLangua… #91128
Conversation
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write If you have received no comments on your PR for a week, you can request a review If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
@llvm/pr-subscribers-lldb Author: Nicklas Boman (smurfd) ChangesCreate API folder if it does not exist, before creating SBLanguages.h Full diff: https://github.com/llvm/llvm-project/pull/91128.diff 1 Files Affected:
diff --git a/lldb/scripts/generate-sbapi-dwarf-enum.py b/lldb/scripts/generate-sbapi-dwarf-enum.py
index 464eb2afff7d6f..162f76e77ec24a 100755
--- a/lldb/scripts/generate-sbapi-dwarf-enum.py
+++ b/lldb/scripts/generate-sbapi-dwarf-enum.py
@@ -2,6 +2,7 @@
import argparse
import re
+import os
HEADER = """\
//===-- SBLanguages.h -----------------------------------------*- C++ -*-===//
@@ -37,6 +38,10 @@ def emit_enum(input, output):
with open(input, "r") as f:
lines = f.readlines()
+ # Create output folder if it does not exist
+ if not os.path.isdir(os.path.dirname(output)):
+ os.makedirs(os.path.dirname(output))
+
# Write the output.
with open(output, "w") as f:
# Emit the header.
|
related to #90753 |
Thanks @JDevlieghere! i do not have commit access, will you please merge this? |
@@ -37,6 +38,10 @@ def emit_enum(input, output): | |||
with open(input, "r") as f: | |||
lines = f.readlines() | |||
|
|||
# Create output folder if it does not exist | |||
if not os.path.isdir(os.path.dirname(output)): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be simplified: https://docs.python.org/3/library/os.html
if not os.path.isdir(os.path.dirname(output)): | |
os.makedirs(os.path.dirname(output), exist_ok=True) |
Thanks @adrian-prantl, simple is better :) |
@smurfd Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested Please check whether problems have been caused by your change specifically, as How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
llvm#91128) Create API folder if it does not exist, before creating SBLanguages.h (cherry picked from commit dbcfa29)
Create API folder if it does not exist, before creating SBLanguages.h