Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lldb create API folder if it does not exist, before creating SBLangua… #91128

Merged
merged 1 commit into from
May 8, 2024

Conversation

smurfd
Copy link
Contributor

@smurfd smurfd commented May 5, 2024

Create API folder if it does not exist, before creating SBLanguages.h

@smurfd smurfd requested a review from JDevlieghere as a code owner May 5, 2024 15:43
Copy link

github-actions bot commented May 5, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the lldb label May 5, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented May 5, 2024

@llvm/pr-subscribers-lldb

Author: Nicklas Boman (smurfd)

Changes

Create API folder if it does not exist, before creating SBLanguages.h


Full diff: https://github.com/llvm/llvm-project/pull/91128.diff

1 Files Affected:

  • (modified) lldb/scripts/generate-sbapi-dwarf-enum.py (+5)
diff --git a/lldb/scripts/generate-sbapi-dwarf-enum.py b/lldb/scripts/generate-sbapi-dwarf-enum.py
index 464eb2afff7d6f..162f76e77ec24a 100755
--- a/lldb/scripts/generate-sbapi-dwarf-enum.py
+++ b/lldb/scripts/generate-sbapi-dwarf-enum.py
@@ -2,6 +2,7 @@
 
 import argparse
 import re
+import os
 
 HEADER = """\
 //===-- SBLanguages.h -----------------------------------------*- C++ -*-===//
@@ -37,6 +38,10 @@ def emit_enum(input, output):
     with open(input, "r") as f:
         lines = f.readlines()
 
+    # Create output folder if it does not exist
+    if not os.path.isdir(os.path.dirname(output)):
+        os.makedirs(os.path.dirname(output))
+
     # Write the output.
     with open(output, "w") as f:
         # Emit the header.

@smurfd
Copy link
Contributor Author

smurfd commented May 5, 2024

related to #90753

@smurfd
Copy link
Contributor Author

smurfd commented May 6, 2024

Thanks @JDevlieghere! i do not have commit access, will you please merge this?

@@ -37,6 +38,10 @@ def emit_enum(input, output):
with open(input, "r") as f:
lines = f.readlines()

# Create output folder if it does not exist
if not os.path.isdir(os.path.dirname(output)):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified: https://docs.python.org/3/library/os.html

Suggested change
if not os.path.isdir(os.path.dirname(output)):
os.makedirs(os.path.dirname(output), exist_ok=True)

@smurfd
Copy link
Contributor Author

smurfd commented May 6, 2024

Thanks @adrian-prantl, simple is better :)

@adrian-prantl adrian-prantl merged commit dbcfa29 into llvm:main May 8, 2024
3 checks passed
Copy link

github-actions bot commented May 8, 2024

@smurfd Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

adrian-prantl pushed a commit to adrian-prantl/llvm-project that referenced this pull request May 8, 2024
llvm#91128)

Create API folder if it does not exist, before creating SBLanguages.h

(cherry picked from commit dbcfa29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants