Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LangRef] callbr result can be used in all successors #91167

Merged
merged 2 commits into from
May 7, 2024

Conversation

nikic
Copy link
Contributor

@nikic nikic commented May 6, 2024

Originally, the callbr result could only be used on the fallthrough destination. This limitation has been lifted, and the result is now also available on the indirect destinations. However, LangRef was not updated to reflect this.

Originally, the callbr result could only be used on the fallthrough
destination. This limitation has been lifted, and the result is
now also available on the indirect destinations. However, LangRef
was not updated to reflect this.
@llvmbot
Copy link
Collaborator

llvmbot commented May 6, 2024

@llvm/pr-subscribers-llvm-ir

Author: Nikita Popov (nikic)

Changes

Originally, the callbr result could only be used on the fallthrough destination. This limitation has been lifted, and the result is now also available on the indirect destinations. However, LangRef was not updated to reflect this.


Full diff: https://github.com/llvm/llvm-project/pull/91167.diff

1 Files Affected:

  • (modified) llvm/docs/LangRef.rst (+2-2)
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst
index 6291a4e57919a5..95937ffd062c6d 100644
--- a/llvm/docs/LangRef.rst
+++ b/llvm/docs/LangRef.rst
@@ -9113,8 +9113,8 @@ instruction in most regards. The primary difference is that it
 establishes an association with additional labels to define where control
 flow goes after the call.
 
-The output values of a '``callbr``' instruction are available only to
-the '``fallthrough``' block, not to any '``indirect``' blocks(s).
+The output values of a '``callbr``' instruction are available both on the
+the '``fallthrough``' block, and any '``indirect``' blocks(s).
 
 The only use of this today is to implement the "goto" feature of gcc inline
 assembly where additional labels can be provided as locations for the inline

Copy link
Collaborator

@efriedma-quic efriedma-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

llvm/docs/LangRef.rst Outdated Show resolved Hide resolved
Co-authored-by: Eli Friedman <efriedma@quicinc.com>
@nikic nikic merged commit de8cf69 into llvm:main May 7, 2024
4 of 5 checks passed
@nikic nikic deleted the langref-callbr-fix branch May 7, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants