Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][fenv] Add missing FE_* definitions for some environment. #91519

Merged
merged 2 commits into from
May 8, 2024

Conversation

lntue
Copy link
Contributor

@lntue lntue commented May 8, 2024

No description provided.

@llvmbot llvmbot added the libc label May 8, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented May 8, 2024

@llvm/pr-subscribers-libc

Author: None (lntue)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/91519.diff

1 Files Affected:

  • (modified) libc/hdr/fenv_macros.h (+24)
diff --git a/libc/hdr/fenv_macros.h b/libc/hdr/fenv_macros.h
index 041fca5f224b3..2ebff4caba90d 100644
--- a/libc/hdr/fenv_macros.h
+++ b/libc/hdr/fenv_macros.h
@@ -17,10 +17,34 @@
 
 #include <fenv.h>
 
+// In some environment, FE_ALL_EXCEPT is set to 0 and the remaining exceptions
+// FE_* are missing.
+#if (FE_ALL_EXCEPT == 0)
+#ifndef FE_DIVBYZERO
+#define FE_DIVBYZERO 0
+#endif // FE_DIVBYZERO
+
+#ifndef FE_INEXACT
+#define FE_INEXACT 0
+#endif // FE_INEXACT
+
+#ifndef FE_INVALID
+#define FE_INVALID 0
+#endif // FE_INVALID
+
+#ifndef FE_OVERFLOW
+#define FE_OVERFLOW 0
+#endif // FE_OVERFLOW
+
+#ifndef FE_UNDERFLOW
+#define FE_UNDERFLOW 0
+#endif // FE_UNDERFLOW
+#else
 // If this is not provided by the system, define it for use internally.
 #ifndef __FE_DENORM
 #define __FE_DENORM (1 << 6)
 #endif
+#endif
 
 #endif // LLVM_LIBC_FULL_BUILD
 

@lntue lntue requested a review from Prabhuk May 8, 2024 19:04
@lntue lntue merged commit e37bd6c into llvm:main May 8, 2024
4 checks passed
@lntue lntue deleted the fenv branch May 8, 2024 21:32
@nickdesaulniers
Copy link
Member

"some environment" ? Got any more details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants